Repository navigation
fix(security): block repo-configured exec during scans + release hardening - #37
Merged
Merged
Conversation
git status runs the program named by core.fsmonitor, so scanning a folder containing a crafted repo could execute arbitrary code. All git calls now go through gitstatus.Command, which sets -c core.fsmonitor=false, --no-optional-locks (status no longer rewrites .git/index) and GIT_TERMINAL_PROMPT=0. Adds a regression test with a real fsmonitor hook. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- install.sh verifies SHA-256 against checksums.txt; curl fails on HTTP errors - main.version is now a var so -ldflags -X works (every release said 1.0.1) - nudge uses the running version instead of a stale constant - release workflow: actions pinned to SHAs, GoReleaser pinned to v2.18.2 - CI: govulncheck step; Dependabot for gomod and github-actions - CHANGELOG entry for 1.4.0 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Kilo Code Review could not run — your account is out of credits. Add credits or switch to a free model to enable reviews on this change. |
CI and GoReleaser built with go1.26.0, whose os package is affected by GO-2026-4602 (reachable via workspace.CompleteDirectoryPath). The toolchain directive makes builds use 1.26.8 while keeping go 1.26.0 as the minimum. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git statusruns the program named by a repo'score.fsmonitor, so scanning a folder containing a crafted repo (for example an unzipped archive) could execute arbitrary code. All git calls now go throughgitstatus.Command, which sets-c core.fsmonitor=false,--no-optional-locks(status no longer rewrites.git/index) andGIT_TERMINAL_PROMPT=0. A regression test uses a real fsmonitor hook.checksums.txt;curl -fso HTTP errors fail instead of installing an error page.main.versionwas aconst, so-ldflags -Xwas ignored and every release reported1.0.1. Now avar; the star nudge uses the running version.Test plan
go test -race ./...passes; newTestStatus_IgnoresRepoFsmonitorfailed before the fixgo vet,gofmt, govulncheck v1.8.0 cleango build -ldflags "-X main.version=9.9.9"reports 9.9.9Known trade-off: bulk fetch (
F) still honours per-repocore.sshCommandso custom SSH setups keep working. Scans never run it.🤖 Generated with Claude Code