Skip to content

remove extra forward slashes #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Artur-man wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

remove extra forward slashes #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/ZarrSparseMatrixSeed-class.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ read_sparse_zarr_component <- function(zarr_store, group, name,
if (!zarr_exists(zarr_store, group))
stop(wmsg("Group \"", group, "\" does not exist in this Zarr store"))
if (zarr_node_is_dataset(zarr_store, group)) {
is_X_or_layer <- group == "/X" || startsWith(group, "/layers/")
is_X_or_layer <- group == "X" || startsWith(group, "layers")
msg1 <- c("\"", group, "\" is a Zarrr dataset, not a Zarr group, ",
"so it looks like the matrix that you are trying to ",
"access is not stored in a sparse format. Please ",
Expand Down
2 changes: 0 additions & 2 deletions R/utils.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,6 @@ normarg_zarr_group <- function(name, what1="'name'",
stop(wmsg(what1, " cannot be the empty string"))
if (startsWith(name, "/")) {
name <- sub("^/*", "/", name) # only keep first leading slash
} else {
name <- paste0("/", name)
}
name
}
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-writeZarrArray.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ test_that("ZarrRealizationSink()", {
sink <- ZarrRealizationSink(c(85, 20, 300), zarr_version=zarr_version)
expect_true(is(sink, "ZarrRealizationSink"))
expect_true(is(sink, "RealizationSink"))
format <- ZarrArray:::get_zarr_format(paste0(sink@zarr_path, "/"))
format <- ZarrArray:::get_zarr_format(sink@zarr_path)
expect_identical(format, zarr_version)
seed <- as(sink, "ZarrArraySeed")
expect_true(is(seed, "ZarrArraySeed"))
Expand Down