You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have also corrected some surplus comments leftover from HDF5Array.
Should we add a few line of code to vignettes too? I did not add there anything for this PR, since we did not add any in the sparse matrix PR either but let me know.
Yeah adding a section in the vignette about the new ZarrSparseMatrix/ZarrADMatrix stuff is a good idea but let's do this in a separate PR.
Oh I forgot to mention that I'm using zarr_store for the first argument of ZarrSparseMatrixSeed() and ZarrSparseMatrix() to distinguish it from the first argument of ZarrArraySeed() and ZarrArray() which is zarr_path. Can you use zarr_store for ZarrADMatrixSeed() and ZarrADMatrix() too? Thanks.
BTW I think I will change ZarrArraySeed() and ZarrArray() interface at some point to also use zarr_store / name for consistency with ZarrSparseMatrixSeed() and ZarrSparseMatrix(). This will allow the user to access a dense matrix stored within an AnnData-style Zarr store in a way that is consistent with how they access a sparse matrix.
BTW I think I will change ZarrArraySeed() and ZarrArray() interface at some point to also use zarr_store / name for consistency with ZarrSparseMatrixSeed() and ZarrSparseMatrix()
Ah please ... it is actually really hard to work around this non-group based interface to zarr, we can at least have em in ZarrArray.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @hpages, I am assuming you are ok with the naming of
ZarrADMatrix, otherwise checks are passing except for some tests unrelated to this PR, e.g.I have also corrected some surplus comments leftover from
HDF5Array.Should we add a few line of code to
vignettestoo? I did not add there anything for this PR, since we did not add any in the sparse matrix PR either but let me know.