Repository navigation
Check C jet costs in the jet decoding tests - #353
Merged
apoelstra merged 1 commit intoNov 4, 2026
Merged
Conversation
The FFI tests decode every Bitcoin and Elements jet with the C decoder and compare its CMR with Haskell's, but not its cost. The C cost is what libsimplicity charges against the budget, and it is stored separately from the CMR in primitiveJetNode.inc, so compare it with Haskell's jetCost as well. Assisted by: Claude Opus 5.5 xhigh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM suggested this additional test to check that the Haskell spec'ed costs match the c costs. We currently check only the CMR's match. The generated rust jets use the Haskell spec, so this will complete the circle for testing rust jets match the c jets, in terms of cost at least.
LLM description:
The FFI tests decode every Bitcoin and Elements jet with the C decoder and compare its CMR with Haskell's, but not its cost. The C cost is what libsimplicity charges against the budget, and it is stored separately from the CMR in primitiveJetNode.inc, so compare it with Haskell's jetCost as well.
Assisted by: Claude Opus 5.5 xhigh