fix(Fluent): restore btn-xs sizing overridden by theme .btn rule - #1106
Merged
Conversation
|
Thanks for your PR, @h2ls. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a Fluent theme rule to explicitly restore extra-small button (.btn-xs) sizing variables that were being overridden by the theme’s general .btn rule, ensuring TableCellButton and other xs buttons keep their intended compact size. Flow diagram for Fluent extra-small button sizing overrideflowchart TD
A[TableCellButton uses btn-xs] --> B[Fluent theme loads general .btn rule]
B --> C[Equal selector specificity causes xs sizing to be overridden]
C --> D[Later .btn-xs and .btn-group-xs > .btn rule restores xs variables]
D --> E[Compact extra-small button size]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull request overview
Restores extra-small button sizing in the Fluent theme for components such as TableCellButton.
Changes:
- Adds
.btn-xsand.btn-group-xs > .btnsizing overrides. - Synchronizes formatted and minified Fluent stylesheets.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/components/BootstrapBlazor.Theme.Fluent/wwwroot/fluent.min.css |
Adds the minified extra-small button override. |
src/components/BootstrapBlazor.Theme.Fluent/wwwroot/fluent.css |
Adds readable extra-small button variables. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
# Conflicts: # src/components/BootstrapBlazor.Theme.Fluent/wwwroot/fluent.min.css
h2ls
force-pushed
the
fix/fluent-theme-btn-xs
branch
from
August 25, 2026 03:20
401d3fc to
5188672
Compare
ArgoZhang
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #1105
Summary By Copilot
Fluent 主题的
.btn规则(--bs-btn-font-size/--bs-btn-line-height/--bs-btn-padding-y)与组件库.btn-xs同为单类选择器、优先级相同,但主题后加载,导致TableCellButton(默认btn-xs)的尺寸变量被覆盖成正常按钮大小。本 PR 在主题.btn规则之后补充.btn-xs, .btn-group-xs > .btn规则,恢复组件库默认值($bs-btn-xs-*与 Bootstrap 默认 line-height 1.5),同步更新fluent.css与fluent.min.css。Regression?
Risk
仅新增一条
.btn-xs变量恢复规则,不影响其他按钮尺寸。Verification
已在应用层 site.css 以相同规则验证:xs 按钮恢复小尺寸。
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Restore Fluent theme sizing variables for extra-small buttons overridden by the theme’s general button styles.
Bug Fixes:
Chores: