session mbedtls, openssl UPDATE optionally enforce EKU and KU#619
Conversation
niklas-moser
force-pushed
the
tls_client_enforce_eku_and_ku_extensions
branch
2 times, most recently
from
9b0567c to
8e7e05a
Compare
Roytak
left a comment
Roytak
left a comment
There was a problem hiding this comment.
Looks good, but needs a bit of refactor.
niklas-moser
force-pushed
the
tls_client_enforce_eku_and_ku_extensions
branch
from
8e7e05a to
824a417
Compare
|
Thank you! I updated the branch, let me know what you think |
Roytak
left a comment
Roytak
left a comment
There was a problem hiding this comment.
Last comment from me, otherwise LGTM. Will wait for Michal to look at it and merge it when he comes back next week.
niklas-moser
force-pushed
the
tls_client_enforce_eku_and_ku_extensions
branch
from
824a417 to
e6f89fb
Compare
|
Okay, updated the PR. Thanks! |
michalvasko
left a comment
michalvasko
left a comment
There was a problem hiding this comment.
Just some minor changes are needed. As for formatting (the failed tests), a newline is expected before #endif. But please also add one after every #ifxxx, thanks.
niklas-moser
force-pushed
the
tls_client_enforce_eku_and_ku_extensions
branch
from
e6f89fb to
d564c9d
Compare
|
Thank you, I updated the PR with the newlines and using |
michalvasko
left a comment
michalvasko
left a comment
There was a problem hiding this comment.
I am not exactly sure why, but uncrustify does not like the newlines in session_mbedtls.c on 838 and 843andsession_openssl.con519and524. Best to just run uncrustify` locally but if you remove these 4 newlines, the tests should finally pass.
…Key Usage (KU) set by client, optional through compile-time flag Signed-off-by: Niklas Moser <niklas.moser@srs.io>
niklas-moser
force-pushed
the
tls_client_enforce_eku_and_ku_extensions
branch
from
d564c9d to
3d6aa74
Compare
|
Done! |
3 participants
Continuation of this PR, with
develas target branch.