diff BUGFIX climb data tree parents to cross schema-mount boundary#2542
Merged
Conversation
In lyd_diff_dup(), the parent-climbing loop used lysc_data_parent() to find the next parent, which returns NULL at a schema mount boundary. This caused the diff to miss the host module's parent containers around mounted module data. Use the data tree parent (node_parent->parent) instead, which crosses the mount boundary correctly. Also stop climbing once the existing diff parent level is reached.
michalvasko
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In lyd_diff_dup(), the parent-climbing loop used lysc_data_parent() to find the next parent, which returns NULL at a schema mount boundary. This caused the diff to miss the host module's parent containers around mounted module data.
Use the data tree parent (node_parent->parent) instead, which crosses the mount boundary correctly. Also stop climbing once the existing diff parent level is reached.