fix(desktop): don't close picker webview before window screenshot - #2054
Open
oshtz wants to merge 1 commit into
Open
fix(desktop): don't close picker webview before window screenshot#2054oshtz wants to merge 1 commit into
oshtz wants to merge 1 commit into
Conversation
![tembo[bot]](https://avatars.githubusercontent.com/in/1223475?s=60&v=4){kind=small}
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Keep the window screenshot picker alive until takeScreenshot is dispatched on Windows. Close target-selection overlays on every capture outcome without allowing cleanup failures to mask the original error.
oshtz
force-pushed
the
fix/window-screenshot-picker-webview
branch
from
July 29, 2026 21:47
355d05c to
113201a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2046.
Problem
On Windows, selecting a window for a screenshot closed the target-picker webview before its
takeScreenshotIPC call could be dispatched, so no screenshot was captured.Fix
Verification