Repository navigation
Conversation
Blur-off Linux instant recording expanded each camera frame to full BGRA and then bilinear-scaled that to the overlay. The compositor now scales even-width YUYV422 directly. Blur still publishes the filtered BGRA frame. Horizontal mirror reverses packed YUYV macropixels before that single scale, so the compositor does not mirror a second time. Release profile (opt-level=s, codegen-units=1, thin LTO), Intel Xeon, rustc 1.88.0. Warmup 8, 31 samples, median at sorted index 15. scaler BGRA 1920x1080 -> RGBA 576x324 median 5.950 ms scaler YUYV 1920x1080 -> RGBA 576x324 median 1.134 ms e2e two-stage median 14.644 ms e2e direct median 1.770 ms e2e direct mirrored median 2.430 ms Max abs channel delta versus the two-stage bilinear on a 1080p luma gradient is 58. Flat color stays within 8. This is one bilinear resample from YUYV, not the previous full-frame BGRA expand plus a second scale.
Contributor
Author
|
@greptileai review |
Contributor
|
@kyzer1023 is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
The overlay test derived its expected row from mirror_yuyv_row and used pairs with identical luma and chroma, so those mistakes still passed.
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Blur-off X11 instant recording scales the camera overlay from packed YUYV422 instead of expanding every frame to full BGRA first. One bilinear swscale (
YUYV422→ overlay RGBA). Blur still publishes filtered BGRA. Horizontal mirror reverses YUYV macropixels before scale.Benchmarks
Hardware: Intel Xeon (4 vCPU), rustc 1.88.0, release (
opt-level=s,codegen-units=1, thin LTO). Warmup 8, 31 samples, median at sorted index 15.Pixel fidelity
One YUYV resample is not bit-identical to the old two-stage bilinear. On a 1080p luma gradient with constant non-neutral chroma, max abs channel delta is 58. Flat color stays within 8.
Tests
cargo test -p cap-recording --lib instant_recording::linux_camera::tests— 50 passed, 4 ignored.Notes
8373bd761onperf/linux-camera-yuyv-overlay-scale.
The PR appears safe to merge; no new actionable issues were found.Summary
The PR scales blur-off Linux camera overlays directly from packed YUYV. It keeps blurred frames on the BGRA path and adds mirror coverage.
Reviews (8) · Last reviewed commit: "fix: allow busy Wayland compositors to e..." · Reviewed by Greptile