Repository navigation
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
@kyzer1023 is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use D3D11 VideoProcessorBlt to scale resized WGC frames into pooled GPU targets. The software encoder reads back only the output-sized texture, and initialization or blit failures retain the existing CPU scaling fallback.
Synthetic texture benchmark medians (3 runs × 12 frames), Ryzen 7 8745HS / Radeon 780M, Windows:
Synthetic output matched the CPU scaler within 1 channel value maximum error in both cases.
Validation:
cargo fmt --all --check,cargo check -p cap-recording, andcargo clippy -p cap-recording -- -D warningspassed. The D3D11 benchmark/pixel test passed.cargo test -p cap-recordinghad three existing AMF instant-mode scenario failures; the 50+ segment case also fails identically on upstreammainat60ef63232.

Confidence Score: 5/5
The PR appears safe to merge, with no actionable new issues found.Summary
This PR scales resized Windows capture frames with D3D11 and keeps CPU scaling as a fallback.
No actionable new issues or repository-rule violations were found.
Reviews (6) · Last reviewed commit: "fix: allow busy Wayland compositors to e..." · Reviewed by Greptile