Repository navigation
Conversation
Decode Linux MJPEG at the largest FFmpeg lowres that still covers the instant overlay. Studio holds full resolution, and the first captured frame stays native so VideoInfo does not shrink. Blur coverage stays at least 640x360.
Contributor
|
@kyzer1023 is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Clippy -D warnings fails on macOS and Windows because idct_lowres and scaled_dimensions are only used by the Linux capture path.
Contributor
Author
|
@greptileai review |
Clippy -D warnings fails on macOS and Windows because overlay_target is only called from the Linux capture path. Keep the method for tests so the budget checks still compile on every target.
Contributor
Author
|
@greptileai please re-review — Clippy fix: |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linux instant MJPEG uses the largest FFmpeg
lowreswhose decoded frame still covers the overlay. A 1080p camera into the default 324 bubble decodes at 1/2 (960×540). Studiosources::Cameraholds full resolution for the whole segment (that hold wins over any overlay budget). The first captured frame is always full resolution, soVideoInfostays the camera size. Blur raises the budget to at least 640×360. YUYV / non-MJPEG unchanged. macOS and Windows ignore the budget.Benchmarks
Same 1920×1080 q=4 JPEG (40072 bytes) → 324×324 bubble, decode + reused bilinear scale to BGRA, 40 iterations, 3 runs (release).
Max channel Δ vs full+bilinear: 2 (mean 0.233). Noisier/high-bitrate JPEGs spend more in Huffman → smaller speedup.
Notes
08b3ac67donperf/camera-mjpeg-scaled-idct.
The PR appears safe to merge; no new blocking issues were found.Summary
The PR reduces Linux MJPEG decode work for Instant camera overlays while keeping Studio camera tracks at full resolution.
Reviews (9) · Last reviewed commit: "fix: retry transient native dependency d..." · Reviewed by Greptile