Skip to content

fix(extension): keep upload progress tied to its recording - #3499

Merged
richiemcilroy merged 2 commits into
CapSoftware:mainfrom
AksharP5:upload-page-identity
Oct 30, 2026
Merged

richiemcilroy merged 2 commits into
CapSoftware:mainfrom
AksharP5:upload-page-identity

Conversation

@AksharP5

@AksharP5 AksharP5 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

An older recording's upload page could lose its Retry and Download controls when another recording started. It could also show the other recording's share link.

Ignore status updates that do not match the video ID in the page URL. The shared renderer covers broadcasts, storage updates and polling; matching-recording progress and completion continue normally. Intentional navigation by the service worker is unchanged.

Page for failed recording A Before After
Recording B starts or publishes storage updates A's error and recovery controls are replaced A's error, Retry and Download remain visible
B completes A's page can show B's link and redirect Update ignored
A uploads and completes Shows A's progress and link Same result

Three regressions fail on the baseline and pass with the fix; the matching-recording control passes in both. All 43 extension tests pass using the repository HTML and actual upload module with Chrome boundary fixtures. Explicit jsdom test dependencies reuse existing locked versions; no resolved package versions changed.

Package typecheck and all production builds pass. Independent GPT-6 Astra HIGH review passed all 43 tests plus seven additional identity/retry probes, reproduced baseline failures, and verified the frozen install. Tests do not mount a Chrome extension or perform live uploads. Reloading an old A page after global state has already moved to B does not restore historical progress; this patch prevents it from displaying B's state.

Closes #3498.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable issues were found.

Summary

The upload page now ignores status updates for other recordings.

  • Each upload page shows updates only for its recording.

Reviews (2) · Last reviewed commit: "Merge branch 'main' into upload-page-ide..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

@AksharP5 is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@richiemcilroy

Copy link
Copy Markdown
Member

hey @greptileai, please re-review the PR

@richiemcilroy
richiemcilroy merged commit c287795 into CapSoftware:main Oct 30, 2026
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extension upload pages accept status from another recording

2 participants