Skip to content

perf(web): dedupe framer-motion onto the version motion already ships #3533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richiemcilroy merged 2 commits into from
Oct 29, 2026
Merged

perf(web): dedupe framer-motion onto the version motion already ships #3533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b7cf3a
chore(web): type motion variants and transitions explicitly
richiemcilroy Oct 29, 2026
370d565
perf(web): dedupe framer-motion onto the version motion already ships
richiemcilroy Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web/app/(org)/dashboard/_components/Navbar/Items.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ const AdminNavItems = ({ toggleMobileNav }: Props) => {
<PopoverTrigger suppressHydrationWarning asChild>
<motion.div
transition={{
type: "easeInOut",
ease: "easeInOut",
duration: 0.2,
}}
className={clsx(
Expand Down
3 changes: 2 additions & 1 deletion apps/web/app/(org)/dashboard/caps/components/web-recorder-dialog/web-recorder-constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { DetectedDisplayRecordingMode } from "@cap/recorder-core/recorder-constants";
import { Video } from "@cap/web-domain";
import type { Variants } from "framer-motion";
import type { RecordingMode } from "./RecordingModeSelector";

export * from "@cap/recorder-core/recorder-constants";
Expand All @@ -24,7 +25,7 @@ const _detectedDisplayRecordingModeStaysInSync: MutuallyAssignable<
> = true;
void _detectedDisplayRecordingModeStaysInSync;

export const dialogVariants = {
export const dialogVariants: Variants = {
hidden: {
opacity: 0,
scale: 0.9,
Expand Down
4 changes: 2 additions & 2 deletions apps/web/components/pages/HomePage/InstantModeDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"use client";

import { Button } from "@cap/ui";
import { AnimatePresence, motion } from "framer-motion";
import { AnimatePresence, motion, type Variants } from "framer-motion";
import {
BookOpen,
Check,
Expand Down Expand Up @@ -72,7 +72,7 @@ const featureContainerVariants = {
},
};

const featureItemVariants = {
const featureItemVariants: Variants = {
hidden: { opacity: 0, y: 20, scale: 0.97 },
visible: {
opacity: 1,
Expand Down
4 changes: 2 additions & 2 deletions apps/web/components/pages/HomePage/ScreenshotModeDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"use client";

import { Button } from "@cap/ui";
import { AnimatePresence, motion } from "framer-motion";
import { AnimatePresence, motion, type Variants } from "framer-motion";
import {
Aperture,
Check,
Expand Down Expand Up @@ -136,7 +136,7 @@ const featureContainerVariants = {
},
};

const featureItemVariants = {
const featureItemVariants: Variants = {
hidden: { opacity: 0, y: 20, scale: 0.97 },
visible: {
opacity: 1,
Expand Down
4 changes: 2 additions & 2 deletions apps/web/components/pages/StudentDiscountPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ import {
faUsers,
} from "@fortawesome/free-solid-svg-icons";
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
import { motion } from "framer-motion";
import { motion, type Variants } from "framer-motion";
import { useState } from "react";
import { toast } from "sonner";

const fadeIn = {
const fadeIn: Variants = {
hidden: { opacity: 0, y: 20 },
visible: (custom: number = 0) => ({
opacity: 1,
Expand Down
4 changes: 2 additions & 2 deletions apps/web/components/pages/seo/GoogleDriveScreenRecorderPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
} from "@fortawesome/free-solid-svg-icons";
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
import clsx from "clsx";
import { AnimatePresence, motion } from "framer-motion";
import { AnimatePresence, motion, type Variants } from "framer-motion";
import {
ArrowLeftRight,
Building2,
Expand Down Expand Up @@ -173,7 +173,7 @@ const steps = [
},
];

const fadeUp = {
const fadeUp: Variants = {
hidden: { opacity: 0, y: 24 },
visible: (custom: number) => ({
opacity: 1,
Expand Down
2 changes: 1 addition & 1 deletion apps/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
"effect": "^3.18.4",
"ffmpeg-static": "^5.3.0",
"file-saver": "^2.0.5",
"framer-motion": "^11.13.1",
"framer-motion": "^12.42.2",
"geist": "^1.3.1",
"gif.js": "0.2.0",
"hls.js": "^1.5.3",
Expand Down
14 changes: 4 additions & 10 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading