Skip to content

fix(scap-direct3d): compare in-flight frames to pool size instead of content size (#3594) #3600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghazy2001 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −5
Open

fix(scap-direct3d): compare in-flight frames to pool size instead of content size (#3594) #3600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions crates/scap-direct3d/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,11 +730,18 @@ impl Capturer {

// A frame queued before the pool was recreated: its
// surface is the old size, and the next frame is not.
if follow_item_size
&& (surface_desc.Width, surface_desc.Height)
!= (content_width, content_height)
{
return Ok(());
if follow_item_size {
let (expected_width, expected_height) = {
let size = pool_size
.lock()
.unwrap_or_else(|poisoned| poisoned.into_inner());
(size.0.max(0) as u32, size.1.max(0) as u32)
};
if (surface_desc.Width, surface_desc.Height)
!= (expected_width, expected_height)
{
return Ok(());
}
}

let frame = if let Some((cropped_texture, crop)) = crop_data.clone() {
Expand Down
Loading