Repository navigation
fix(web): enforce comment and reaction settings in web comment actions - #3608
Open
yashranaway wants to merge 3 commits into
Open
yashranaway wants to merge 3 commits into
yashranaway wants to merge 3 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Author
|
@greptileai review |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
turning off comments or reactions on a video (or at the org or space level) only hid the comment box on the share page. the server actions behind it never checked the setting, so anyone with the page already open, or calling the action directly, could still post comments, replies, reactions and voice or video notes, which also notified the owner and uploaded into their bucket. the mobile and agent apis already enforce this, the web actions were the gap.
now new comments check the effective setting (video, org and space, resolved the same way the share page does) after the access check, and media comments are refused when comments are off, which also stops the upload before anything hits storage.
The PR appears safe to merge; both earlier findings are fixed and no new actionable issues remain.Summary
The PR checks video, organization, and space settings before accepting web comments, replies, reactions, or media comments.
Reviews (3) · Last reviewed commit: "test(web): mock awaitable comment querie..." · Reviewed by Greptile