Repository navigation
fix(web): stop showing screenshot Caps as uploading in the mobile app - #3611
Open
yashranaway wants to merge 2 commits into
Open
yashranaway wants to merge 2 commits into
yashranaway wants to merge 2 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Author
|
@greptileai review |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Author
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
an image imported on the web showed up in the mobile app as stuck uploading forever: no thumbnail, no download, the app kept polling it, and other people's views in the app were never counted. the web dashboard and share page show the same cap fine.
the web import leaves an upload progress row behind for screenshots, and the web already ignores those rows for screenshots everywhere. the mobile api never got that rule, so four of its queries (caps list, statuses, detail and view tracking) read the row as an active upload. now they all join upload rows only for caps that aren't screenshots, which also fixes caps already affected.
The PR appears safe to merge, with no actionable findings.Summary
The mobile API now ignores leftover upload rows for screenshots across list, status, detail, and view tracking queries.
Reviews (2) · Last reviewed commit: "test(web): check the screenshot upload f..." · Reviewed by Greptile