Repository navigation
fix(web): resume HLS playback when signed segment URLs expire - #3613
Open
yashranaway wants to merge 3 commits into
Open
yashranaway wants to merge 3 commits into
yashranaway wants to merge 3 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hls segment urls are signed for an hour. when they expired mid watch (long video, or a tab paused for a while) the player did refresh the playlist, but reloading the same source rebuilt the media source, so the video jumped back to 0:00, paused, at 1x. and if a segment was refused for good (s3 also returns 403 for a missing object) it reloaded the playlist in a tight loop, i saw over a thousand playlist requests in 45 seconds, each one re-signing every segment on the server.
now it keeps the position, paused state and speed across the refresh and resumes, and it remembers which fragment triggered the reload so the same fragment refused again with fresh urls falls through to the normal retry and error path instead of looping. mp4 playback is untouched.
The PR appears safe to merge, with both previous findings addressed and no new actionable issues found.Summary
The PR preserves playback position, speed, and play state when signed HLS URLs expire.
Reviews (4) · Last reviewed commit: "fix(web): key the URL refresh guard on f..." · Reviewed by Greptile