Repository navigation
fix(web): recover failed Loom imports from the mobile app - #3615
Open
yashranaway wants to merge 2 commits into
Open
yashranaway wants to merge 2 commits into
yashranaway wants to merge 2 commits into
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a loom import started from the mobile app handled failures badly. if the import workflow failed to start the video sat on "importing from loom" with no failure recorded, and any retry with that link got a 400 because the stuck one counted as already imported, at least until the recovery cron picked it up. storage or restart failures also came back as 400, so the app told people the video might be private when it was a server problem. the same link would just restart on the web.
the mobile route had its own copy of the import flow without the web's recovery. now it keeps its own url, pro, org and rate limit checks and calls the same import helper the web and csv imports use, so failed imports restart and start failures get recorded, and server side failures return 500 while real client errors stay 400. that also drops about 100 duplicated lines. the new test is added to the ci list.


Confidence Score: 5/5
The PR appears safe to merge; no new actionable issues remain.Summary
Mobile Loom imports now use the shared import helper, which records startup failures and lets users restart failed imports.
Reviews (3) · Last reviewed commit: "fix(web): report Loom startup failures a..." · Reviewed by Greptile