Repository navigation
fix(web): forget web edits when a desktop reupload replaces the recording - #3616
Open
yashranaway wants to merge 2 commits into
Open
yashranaway wants to merge 2 commits into
yashranaway wants to merge 2 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after trimming a video on the web we keep an edit record and a copy of the original. if you then reupload from the desktop editor to the same link, the new file replaced the video but both of those stayed. so "restore original" brought back the old recording and threw away the reupload, the next web trim rendered from the old original and silently dropped the reupload, and the transcript editor kept the old words.
now the reupload deletes the edit record in the same transaction that publishes it. the first trim after that throws away any leftover original copy and preserves the current recording again (after it has claimed the upload row, so nothing races it), and stored words are ignored until the new transcription finishes.
The PR appears safe to merge with the remaining copy race explicitly accepted.Summary
Desktop reuploads clear saved web edits. The next trim replaces the leftover original copy after claiming the recording, and transcript reuse now requires
transcriptionStatusto beCOMPLETE.Reviews (4) · Last reviewed commit: "fix(web): rebuild the edit original and ..." · Reviewed by Greptile