Repository navigation
fix(auth): keep the invited admin role when joining through SSO - #3617
Open
yashranaway wants to merge 2 commits into
Open
yashranaway wants to merge 2 commits into
yashranaway wants to merge 2 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if an owner invites someone as admin and they join through the org's saml sso (the normal path once sso is on), they came in as a plain member and the admin invite got marked accepted, so the invite link was dead too and someone had to fix the role by hand.
now when sso creates a new membership it checks for a pending admin invite for that org and email in the same transaction and uses admin if there is one. existing memberships keep their role, and invites for other orgs or emails don't count.
The PR appears safe to merge; no new actionable issues were found.Summary
SSO now keeps the invited admin role when creating a membership.
Reviews (3) · Last reviewed commit: "fix(auth): lock the admin invite while p..." · Reviewed by Greptile