Repository navigation
fix(web): only record share views the viewer is allowed to watch - #3618
Open
yashranaway wants to merge 1 commit into
Open
yashranaway wants to merge 1 commit into
yashranaway wants to merge 1 commit into
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the share page view endpoint recorded a view for any video id without checking the requester could watch it. anyone could post the id of a private, password locked or email restricted cap and add views to the owner's analytics, and for newer caps that also created "anonymous viewer" notifications and could send the first view email for a video nobody outside could open. the mobile copy of this endpoint and the share page itself both check access.
now before recording it runs the same view policy the share page uses, on the row it already loads. password protected caps still count once the viewer has entered the password, since the verified password cookie comes along with the request. denied requests just record nothing, same as owner views.
The PR appears safe to merge; denied viewers are stopped before views and notifications are recorded.Summary
The tracking endpoint now checks the viewer’s access before recording a view or starting view notifications and emails.
Reviews (1) · Last reviewed commit: "fix(web): only record share views the vi..." · Reviewed by Greptile