Repository navigation
fix(desktop-gpui): keep caption timing edits and drags instead of snapping back - #3619
Open
yashranaway wants to merge 3 commits into
Open
yashranaway wants to merge 3 commits into
yashranaway wants to merge 3 commits into
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…them like the track
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
retiming a generated caption in the desktop editor didn't stick. dragging it on the timeline, dragging its edges or typing new start and end times in the caption panel all snapped it straight back to where it was, and left the saved caption inconsistent with its own words.
the edit wrote the new start and end onto the source caption but kept the old word timings, and the caption track is re-derived from word bounds whenever a caption has words, which every whisper or parakeet caption does. now the words are mapped onto the caption's new span, so a move shifts them and an edge drag stretches them. text only edits come out unchanged, and the shared derivation that export and render use is untouched.
The PR appears safe to merge; the latest changes address the earlier timing failures without an established new regression.Summary
The PR saves caption timing edits by moving word times with the caption.
Reviews (3) · Last reviewed commit: "fix(desktop-gpui): retime caption words ..." · Reviewed by Greptile