Repository navigation
fix(media-server): re-encode H.264 uploads that are not 8-bit 4:2:0 - #3620
Open
yashranaway wants to merge 1 commit into
Open
yashranaway wants to merge 1 commit into
yashranaway wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Author
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uploading an h.264 video that's 4:4:4, 4:2:2 or 10-bit got the stream copied as is. processing said success, but safari, ios and firefox on windows can't decode those, so the share page just didn't play. these aren't rare, ffmpeg screen captures without a pixel format default to 4:4:4 and obs can record i444 or 10-bit.
the transcode decision only looked at size and level, never the pixel format, and the level retag shortcut had the same gap. now processing also probes the pixel format (in parallel with the level probe) and transcodes anything that isn't 8-bit 4:2:0, skipping the retag shortcut for it. every encoder path already outputs 4:2:0, and if the probe fails it behaves like before.
The PR appears safe to merge.Summary
The PR checks H.264 pixel formats before choosing whether to copy or re-encode video.
Reviews (1) · Last reviewed commit: "fix(media-server): re-encode H.264 uploa..." · Reviewed by Greptile