Repository navigation
fix(desktop-gpui): keep other tracks aligned when changing clip speed after a fullscreen title - #3621
Open
yashranaway wants to merge 2 commits into
Open
yashranaway wants to merge 2 commits into
yashranaway wants to merge 2 commits into
Conversation
… after a fullscreen title
Contributor
Author
|
@greptileai review |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Author
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if a project had a fullscreen title before a clip, changing that clip's speed shifted zooms, text, captions, masks and the other tracks by the wrong amount. e.g. a 3s intro title then two 10s clips, set the second to 2x: a zoom over the first clip at 11 to 12s moved left to 10.5s when it shouldn't move at all, and a zoom inside the second clip at 20s landed at 15s instead of 16.5s.
the speed change computed its shift from clip time without title holds, then applied it to track times that include them. delete and transitions already convert between the two, speed change didn't. now each track time is converted before the shift is worked out, and mask keyframes also bend at the title edges inside the retimed span. projects without fullscreen titles behave exactly as before.
The PR appears safe to merge; no outstanding issues were found.Summary
The PR keeps tracks aligned when clip speed changes around fullscreen titles. It also splits mask animations at title edges.
Reviews (2) · Last reviewed commit: "test(desktop-gpui): cover mask keyframe ..." · Reviewed by Greptile