Repository navigation
fix(desktop-gpui): record without a remembered camera or mic that is unplugged - #3622
Open
yashranaway wants to merge 2 commits into
Open
yashranaway wants to merge 2 commits into
yashranaway wants to merge 2 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Author
|
@greptileai review |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Author
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if your saved camera (or mic, with the no-mic warning off) isn't plugged in when you hit record, the device row says "not connected" but the screen recording then fails with a raw device not found error and records nothing, so the saved camera blocks every recording until you clear it. the tauri app fixed this in #2104 (skip a missing input, only camera-only still needs its camera) but the gpui port lost that skip.
now the start drops a remembered camera or mic that isn't connected and records without it, with camera-only still requiring its camera. it's done where the start config is built so the recording bar's mic state and the rest see the same config. deep links still stay strict since they name a device explicitly.
The PR appears safe to merge; no new actionable issues were found.Summary
Screen recordings skip remembered cameras and microphones that are unplugged. Camera-only recordings still require their camera, and deep links remain strict.
Reviews (2) · Last reviewed commit: "fix(desktop-gpui): rescan cameras and mi..." · Reviewed by Greptile