Implements Non-Legal Cards that choose and create a card - #11874
Merged
Merged
Conversation
…seCardName(SpellAbility, Predicate<ICardFace>, String, String) seems more reasonable since that one already works correctly with the AI.
tool4ever
reviewed
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements:
Svega, the Unconventional and associated token
The Disciple of Nissa
The Disciple of Vess
Form of the Stax Player
Gallery of Legends (Attraction)
Jund 'Em Out
The Ash Lizard
The Crab Queen
The Scholar of Seas
The Wise Sable
Who's That Praetor?
Code Changes
Add the ability to count Planeswalker Types
Prevent crash when Choose Card Name is empty
MakeCard now uses the correct face
Allow multiple elements for ValidCards in NameCard separated with a ,
Allow the ExcludeChosen Parameter in NameCard to be used together with ValidCards
Make sure the AI picks a card from the List in NameCard
Known Issues
the cmc of Backfaces with no mana value is calculated as 0. Not sure what the correct approach would be. CardFace has no information about the front face.