Conversation
khaliostr
added a commit
to witchesofthehill/manabrew
that referenced
this pull request
Sep 16, 2026
Fork commit 16, same as Card-Forge/forge#11932: Self, Enchanted, Equipped and AttachedBy statics start from the one card they know. Exact on three seeds.
tool4ever
reviewed
Sep 16, 2026
…tics Affected$ Card.Self, Creature.EnchantedBy, Creature.EquippedBy and Creature.AttachedBy walked the whole battlefield to find one card the static already knows. AffectedDefined$ Self, Enchanted, Equipped and AttachedBy Self name that card; a type or extra restriction stays as the Affected$ filter. Only statics whose effect and affected zones are the battlefield. Mechanical: 2608 lines in 2404 scripts. The AI read Affected$ as text in five places and now understands AffectedDefined$: applyStaticContPT asks the defined set whether it holds the virtual card, the two haste-source checks skip statics on a defined card, and AttachAi's attachment checks look at AffectedDefined$ first. Same seeds, identical decisions.
khaliostr
force-pushed
the
khaliostr/upstream-affected-defined
branch
from
September 16, 2026 12:27
18e50b4 to
33fc9b3
Compare
khaliostr
added a commit
to witchesofthehill/manabrew
that referenced
this pull request
Sep 16, 2026
Fork commit 16 amended after the Card-Forge/forge#11932 review: Affected$ reduced to the residual filter, five AI readers taught AffectedDefined$. Exact on three seeds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the review on #11931.
Affected$ Card.Self,Creature.EnchantedBy,Creature.EquippedByandCreature.AttachedBywalked the whole battlefield to find one card the static already knows.AffectedDefined$ Self,Enchanted,EquippedandAttachedBy Selfname that card; a type or extra restriction stays as theAffected$filter. Mechanical: 2608 lines in 2404 scripts, only where the effect zone and the affected zone are the battlefield.The AI read
Affected$as text in five places (ComputerUtilCard.applyStaticContPT, the two haste-source checks inComputerUtil, three attachment checks inAttachAi) and now handlesAffectedDefined$. Three seeded four-player games make identical decisions before and after; the widest runs 280 s to 252 s.IsRememberedis left out:Rememberedresolves throughgetCardStateand is not zone-bound, so it is not the same set.