Repository navigation
Add 1password-cli Feature - #16
ghughes610 wants to merge 1 commit into
Conversation
jgarber623-cargosense
left a comment
jgarber623-cargosense
left a comment
There was a problem hiding this comment.
Overall, looks good. Posted a few comments with suggestions.
| "ghcr.io/devcontainers/features/common-utils", | ||
| "ghcr.io/CargoSense/devcontainer-features/apt-packages" |
There was a problem hiding this comment.
| "ghcr.io/devcontainers/features/common-utils", | |
| "ghcr.io/CargoSense/devcontainer-features/apt-packages" | |
| "ghcr.io/devcontainers/features/common-utils" |
The Feature's install.sh handles its own installation dependency checking. Additionally, the common-utils Feature also installs curl and gnupg, so we should be okay with removing the apt-packages Feature from the list.
The installsAfter configuration is also described as a "soft dependency" in the documentation. Seems it influences installation order but doesn't prescribe it. 🤷🏻
|
|
||
| ## OS Support | ||
|
|
||
| This Feature should work on recent versions of Debian/Ubuntu and Linux distributions using the [apt](https://wiki.debian.org/AptCLI) management tool, on `amd64` and `arm64`. |
There was a problem hiding this comment.
| This Feature should work on recent versions of Debian/Ubuntu and Linux distributions using the [apt](https://wiki.debian.org/AptCLI) management tool, on `amd64` and `arm64`. | |
| This Feature should work on recent versions of Debian/Ubuntu and Linux distributions using the [apt](https://wiki.debian.org/AptCLI) management tool and on architectures for which 1Password publishes packages. |
Practically, amd64 and arm64 are what we concern ourselves with, but the 1P APT repo publishes packages for other architectures, too.
|
|
||
| ## Options | ||
|
|
||
| This Feature has no options. It installs the latest `1password-cli` package. |
There was a problem hiding this comment.
| ## Options | |
| This Feature has no options. It installs the latest `1password-cli` package. |
No need to say nothing's there.
| @@ -0,0 +1,30 @@ | |||
| # 1password-cli | |||
|
|
|||
| Install the [1Password CLI](https://developer.1password.com/docs/cli/) (`op`) from 1Password's signed apt repository. | |||
There was a problem hiding this comment.
| Install the [1Password CLI](https://developer.1password.com/docs/cli/) (`op`) from 1Password's signed apt repository. | |
| Install the [1Password CLI](https://developer.1password.com/docs/cli/) (`op`) from 1Password's signed APT repository. |
Extremely pedantic nitpick. 😬
| exit 1 | ||
| fi | ||
|
|
||
| export DEBIAN_FRONTEND=noninteractive |
There was a problem hiding this comment.
| export DEBIAN_FRONTEND=noninteractive | |
| export DEBIAN_FRONTEND="noninteractive" |
|
|
||
| op --version |
There was a problem hiding this comment.
| op --version |
Adding a feature to allow us to use 1Password CLI in some stuff. This should make it easier to do other stuff. If you want to know more about stuff please message me.