[ENG-11880] Fixed missed email sends - #11912
Open
ihorsokhanexoft wants to merge 4 commits into
Open
ihorsokhanexoft wants to merge 4 commits into
ihorsokhanexoft wants to merge 4 commits into
Conversation
ihorsokhanexoft
force-pushed
the
fix/ENG-11880
branch
from
September 14, 2026 16:56
e4f5014 to
d4007fa
Compare
ihorsokhanexoft
changed the title
adlius
requested changes
Sep 18, 2026
| self.registration_approval.add_authorizer(admin, node=node) | ||
| self.registration_approval.save() # Save approval's approval_state | ||
| try: | ||
| self.registration_approval.ask(admins) |
Collaborator
There was a problem hiding this comment.
- So if we
ask()here and inarchive_success()we ask again, doesn't that mean the user will receive two identical emails of the same notification? - If we send the notification here, that means it is possible that the user will approve the registration before archiving is done. What happens then if archiving fails?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-11880
Purpose
Initial approval emails are not sent for usual and embargoed registrations
node_pending_embargo_adminandnode_pending_registration_adminemails are not sent.Changes
From my investigation these emails are sent only when archive process is finished.
archive_successcallsdst.sanction.askthat picks up appropriateAUTHORIZER_NOTIFY_EMAIL_TYPEdepending on the sanction type. It's the only place where these two emails are listed.However when we create a new registration, we call
require_approvalandembargo_registrationinRegistrationCreateSerializerbut don't send emails at all.