Skip to content

[ENG-12182] match queue config to actual celery task names - #11928

Merged
brianjgeiger merged 2 commits into
CenterForOpenScience:feature/pbs-26-18from
mkovalua:fix/ENG--12182
Sep 18, 2026
Merged

brianjgeiger merged 2 commits into
CenterForOpenScience:feature/pbs-26-18from
mkovalua:fix/ENG--12182

Conversation

@mkovalua

Copy link
Copy Markdown
Contributor

Ticket

Purpose

Changes

Side Effects

QE Notes

CE Notes

Documentation

},
'monthly_reporters_go': {
'task': 'management.commands.monthly_reporters_go',
'task': 'osf.management.commands.monthly_reporters_go.monthly_reporters_go',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks

Comment on lines +499 to +502
# Items below are celery task names, not python module paths.
# These tasks set an explicit name= that does not start with their own
# module path, so the module entries above never match them. Listing the
# names keeps them on the intended queue without renaming the tasks

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10 for leaving an explanation (even tho the mismatch is hopefully temporary)

'osf.management.commands.migrate_deleted_date',
'osf.management.commands.addon_deleted_date',
'osf.management.commands.archive_registrations_on_IA'
'osf.management.commands.archive_registrations_on_IA',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 👍

@Ostap-Zherebetskyi Ostap-Zherebetskyi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⭐

@brianjgeiger
brianjgeiger changed the base branch from hotfix/26.21.1 to feature/pbs-26-18 September 18, 2026 12:45
@brianjgeiger

Copy link
Copy Markdown
Collaborator

@mkovalua Could you rebase this on feature/pbs-26-18 please?

@brianjgeiger

Copy link
Copy Markdown
Collaborator

@mkovalua I mentioned in Slack, but the merge migrations are being taken care of by another ticket. Please remove them from here and merge in pbs-26-18 again when I ping you in slack that it's ready.

@brianjgeiger

Copy link
Copy Markdown
Collaborator

@mkovalua Okay, the merge migration has been put into pbs-26-18. Please remove yours and pull the latest feature branch now.

Comment thread website/settings/defaults.py
@brianjgeiger
brianjgeiger merged commit 92e63e2 into CenterForOpenScience:feature/pbs-26-18 Sep 18, 2026
10 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants