Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA. |
Author
|
recheck |
|
Thank you for your contribution. This pull request has been marked as stale as it has not passed the automated tests and there was no activity for the last 14 days. This pull request will be closed due to inactivity after 60 days, if no action is taken. |
…& MRPEs \n\n Add service montoring rules for cached local and MRPE checks that enable the user to toggle whether the caching information is visible in the summary and the details or only the details.
Nipa0
force-pushed
the
toggle-hide-cache-info
branch
from
September 15, 2026 20:26
b49e1b0 to
c79cc08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add service montoring rules for cached local and MRPE checks that enable the user to toggle whether the caching information is visible in the summary and the details or only the details.
--
The representation of the caching information (Cache generated....) in the summary used to make it more difficult to read the actual summary information when looking at the service list, and is for most of our use cases superfluous. I therefore built in the option to disable this representation and replace the whole cache information in the summary with ◷ to indicate it is a cached monitoring keeping the actual caching information only in the details and making the representation more readable.
To be coherent I added this option for both local checks and MRPEs as the processing of cached checks is nearly identical, and the MRPE source code explicitely stated it was written in a manner to be coherent with the local checks.
I am not sure if the way I created the setting options is the best practice way and appreciate feedback on that.