Bundle the appliance's ps1/README/import scripts into the actual release zip - #27
Merged
Conversation
…ase zip The release-attach step shipped only the bare image (gzip for the VHDX, a raw copy for the OVA/qcow2), so Import-DispatchAppliance.ps1 and the per-format READMEs never reached a real release download - only the workflow_dispatch upload_artifacts path had them, contradicting what every appliance README already promised. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The zip-building step only ran when RELEASE_TAG was set (a real release or a manual dispatch with a tag) - normal CI pushes never exercised it, which is exactly how the previous bug (bare vhdx.gz, no ps1/README) went unnoticed. Split zip-building out of the release-only step so it runs unconditionally, and added a check that each zip actually contains its expected files, failing the build loudly if one goes missing again. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/appliance.ymlshipped only the bare image (gzip for the VHDX, a raw copy for the OVA/qcow2), soImport-DispatchAppliance.ps1and the per-format READMEs never reached a real release download - only theworkflow_dispatchupload_artifactspath had them.dispatch-appliance-0.7.0-hyperv.vhdx.gz): it's a bare gzip of the VHDX only.out/<type>dir (image + helper script(s) + README + checksum) per hypervisor, matching what every appliance README already promises ("unzip this file, the .vhdx/README/script land together").Test plan
appliance.ymlYAML parses (python3 -c "import yaml; yaml.safe_load(open('.github/workflows/appliance.yml'))"- done locally)🤖 Generated with Claude Code