Fix stale PostgreSQL claim + version default in the Azure ARM template - #29
Merged
Conversation
The ARM template's description (shown on the Azure Portal deploy blade) and deploy/azure/README.md both claimed install.sh installs PostgreSQL - it doesn't; the actual cloud-init command (azuredeploy.json's cloudInit variable) has only ever called `install.sh --admin-password ... --generate-cert`, which installs Dispatch against its bundled SQLite database. Also bumped the dispatchVersion default (azuredeploy.json, createUiDefinition.json, and the README's parameter table) from 0.7.0 to the current 0.7.1 release. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy/azure/azuredeploy.json's templatedescription(shown on the Azure Portal deploy blade) anddeploy/azure/README.mdboth claimedinstall.shinstalls PostgreSQL - it doesn't. The actualcloudInitcommand in the same file has only ever runinstall.sh --admin-password ... --generate-cert, which installs Dispatch against its bundled SQLite database (no--install-postgresflag - that flag doesn't exist ininstall.sh).dispatchVersiondefault (azuredeploy.json,createUiDefinition.json, and the README's parameter table) from0.7.0to the current0.7.1release, so a fresh one-click deploy doesn't need a manual override to get the latest build.python3 -m json.tool).Found while scrubbing the docs site (dispatch-docs) for the same stale-PostgreSQL pattern - this is the one spot it also existed inside dispatch-platform itself.
Test plan
🤖 Generated with Claude Code