-
Notifications
You must be signed in to change notification settings - Fork 3
fix(lh-102436): prepare PyPI and Galaxy release #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
a5e3cc1
fix(lh-102436):Local credentials cannot enter the Galaxy artifact
huides00 b58da43
fix(lh-102436): Inventory plugin remove exports of the API token
huides00 0396937
fix(lh-102436): hide smart licensing token
huides00 2b3ee4b
fix(lh-102436): install resolves a broken SDK
huides00 bb75c2e
fix(lh-102436): hide api-token
huides00 d7921f6
fix(lh-102436): unresolved runtime dependency
huides00 1d6d303
fix(lh-102436): query correct distribution name
huides00 684b70e
fix(lh-102436): remove tests and e2e files from pypi wheel
huides00 d69bea6
fix(lh-102436): make the Galaxy artifact independently installable an…
huides00 a04e3cd
fix(lh-102436): Galaxy metadata/runtime issues
huides00 3c7b987
fix(lh-102436): poetry run in venv
huides00 7338f0d
fix(lh-102436): stabilizes the final package metadata and README
huides00 e58ecbb
fix(lh-102436): add manual build-once release workflow
huides00 226fb91
fix(lh-102436): harden release and credential workflows
huides00 5765498
fix(lh-102436): use current vault key in CLI E2E
huides00 f2e8f47
fix(lh-102436): close remaining release blockers
huides00 ee0e8c4
fix(lh-102436): use repository secrets for publishing
huides00 3d3e50d
fix(lh-102436): fix doc styling
huides00 081eff8
fix(lh-102436): proper release
huides00 abc5c07
fix(lh-102436): address release review feedback
huides00 3aa71bb
fix(lh-102436): correct gitleaks module path
huides00 d2d36cf
fix(lh-102436): integrate profile workflow with release
huides00 1f408b2
fix(lh-102436): resolve generated documentation conflicts
huides00 68a4b27
fix(lh-102436): align network object service conventions
huides00 79baacf
fix(lh-102436): align network group service conventions
huides00 46ee9a5
fix(lh-102436): make ansible sanity checks pass
huides00 10072f0
fix(lh-102436): vault ansible e2e device password
huides00 6059b6a
fix(lh-102436): prepare first ansible release metadata
huides00 0948029
fix(lh-102436): honor keyword-only object lookups
huides00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| commitizen: | ||
| name: cz_conventional_commits | ||
| version_provider: poetry | ||
| version_provider: pep621 | ||
| tag_format: v$version | ||
| update_changelog_on_bump: false | ||
| version_files: | ||
| - sccfm-ansible/plugins/module_utils/dependencies.py:_PAIRED_DEVKIT_REQUIREMENT |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Keep the protected environment around this write path
Removing
release-botalso removes its secret scoping and any configured deployment protection or approval rules, while this job still obtains a deploy key and pushes directly tomain. Please retain the protected environment and, independently, avoid making the write credential available during dependency installation and documentation generation; inject it only for the final push.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The credential-exposure portion is addressed in
abc5c07: generated-docs now hascontents: read, uses a tokenless checkout, and receives the deploy key only in the final guarded push step with strict host-key checking and cleanup. We intentionally did not restoreenvironment: release-botbecause this repository has no configured GitHub environments and the maintainer selected repository-level secrets. Adding only the YAML key would auto-create an unprotected environment without approval rules or environment-scoped secrets, so it would not add protection. If a protected environment is configured later, the deploy key should move into it.