Skip to content

LH-114214: Add SCCFM agent plugin - #30

Open
huides00 wants to merge 4 commits into
mainfrom
LH-114214-sccfm-agent-plugin
Open

LH-114214: Add SCCFM agent plugin#30
huides00 wants to merge 4 commits into
mainfrom
LH-114214-sccfm-agent-plugin

Conversation

@huides00

Copy link
Copy Markdown
Collaborator

https://cisco-sbg.atlassian.net/browse/LH-114214

Description

This adds an installable SCC Firewall Manager agent plugin for Claude Code and Codex. It guides users through version-matched CLI and Ansible setup, local token configuration, health checks, read-only operations, and safe teardown while keeping plugin versioning independent from the repository release.

Mutating operations now require a reviewed command and an exact, short-lived confirmation before execution. The shared safety gate binds approval to the precise command, prevents edits such as removing --check from being authorized, and is covered by automated tests and end-user documentation.

Package guided setup, teardown, and synchronized CLI and Ansible skills for
Claude Code and Codex.

Gate mutating commands with exact-plan approvals while allowing schema-proven
read-only operations. Document installation, authentication, capabilities, and
the end-user workflow.
Point package-description links at GitHub Pages and GitHub so they remain valid
when the README is rendered on PyPI.

This allows Python artifact verification to accept both the wheel and source
distribution.
@huides00
huides00 marked this pull request as ready for review August 26, 2026 12:55
Add the checked-in collection release entry required after the initial release
seed has already been consumed.

This lets release rehearsal update the date without rewriting published
changelog history.

@afercal afercal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Scoombe Scoombe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found three issues in the safety and teardown paths that are not covered by the current tests.

Comment thread plugins/sccfm/hooks/sccfm_guard.py
Comment thread plugins/sccfm/scripts/setup_runtime.py
Comment thread plugins/sccfm/hooks/hooks.json
Harden the command guard against leading environment assignments and shell wrappers.
Prefixed SCCFM and Ansible commands can no longer bypass review.

Record the exact Ansible collection installed by the setup helper and preserve other reported copies
during teardown. Prefer the owned copy during diagnostics.

Add Windows-specific hook commands to both manifests and cover the findings with regression tests.
@github-actions

Copy link
Copy Markdown

Consistency Check

No consistency issues found.

Checker output
✓ No issues found across 6 file(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants