feat(lh-115196): improve SCCFM plugin setup and safety - #36
Merged
Conversation
Add fast, version-aligned setup, optional Homebrew CLI installation, and a guarded cleanup flow that discovers supported installations while preserving profiles by default. Align command approvals with schema-declared preflights and local Ansible syntax checks, and reduce redundant discovery work. Keep both plugin manifests at version 0.1.1.
huides00
requested review from
Scoombe,
afercal and
siddhuwarrier
as code owners
September 2, 2026 10:54
afercal
approved these changes
Sep 2, 2026
Keep the existing Homebrew CLI and build a private, version-matched Ansible companion instead of stopping setup or exposing another CLI on PATH. Record the companion runtime alongside the managed Galaxy collection, use its exact Ansible executables for discovery and execution, and remove it through the digest-bound cleanup flow. Preserve version 0.1.1 for both plugin manifests and prepare the paired Ansible changelog for the inferred 0.41.0 release.
Consistency CheckNo consistency issues found. Checker output |
Scoombe
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira-eng-rtp3.cisco.com/jira/browse/LH-115196
Description
SCCFM plugin users can install the CLI through Homebrew or use a faster version-aligned managed setup, then remove discovered runtime components through a reviewed cleanup flow that preserves profiles unless their deletion is explicitly confirmed.
Command safety now uses the visible exact execution request, recognizes schema-declared preflights and local Ansible syntax checks, and reduces redundant Ansible discovery while preserving confirmation for real mutations. Both plugin manifests remain at version 0.1.1.
The full automated test suite and repository pre-commit checks pass.