Repository navigation
Conversation
Maven 3.10 rejects a plugin declared twice in one POM (3.9 only warned), so every build of v0.11.0 now fails while reading the POMs. Merge the two maven-jar-plugin declarations into one; the version now comes from pluginManagement (3.4.2), as on main. Only the packages/clickhouse-jdbc-all/pom.xml part of the original commit is taken. The root pom.xml part moves the default-jar manifest configuration out of the profiles, which is not needed for this fix. (cherry picked from commit 91017eb) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Maven 3.10 rejects a dependency declared twice in one POM, so the "Compile examples" CI step fails on v0.11.0. Keep one jackson-databind dependency with the default (compile) scope, as on main. Conflict: the version is 2.18.11 on main and 2.18.10 on v0.11.0. Kept the branch value; the bump is part of the #3233 backport. (cherry picked from commit 2b635d1) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
TriageCategory: Summary What this impacts
Concerns
Required reviewer action
|
|
@ccoltx I will do propagation myself - besides this PR also changes some dependency version. |
Summary
CI on every PR into
v0.11.0fails while reading the POMs. The runners now use Maven 3.10, which rejects a plugin or dependency declared twice in one POM (Maven 3.9 only logged a warning). This PR backports the two fixes frommainfor the two duplicates on the branch:packages/clickhouse-jdbc-all/pom.xml:maven-jar-plugindeclared twice. This breaks "Build and install libraries". The fix takes only theclickhouse-jdbc-allpart of 91017eb (from [repo] Cluster Tests #3187), which merges the two declarations. The plugin version now comes frompluginManagement(jar-plugin.version= 3.4.2), the same as onmain; the second declaration had pinned 3.3.0. The rootpom.xmlpart of 91017eb is left out, because it moves thedefault-jarmanifest configuration out of the release profiles and would change jar manifests of builds that don't use those profiles.examples/client-v2/pom.xml:jackson-databinddeclared twice (testandcompilescope). This breaks "Compile examples". Backport of 2b635d1 ("fixed example build"), which keeps one dependency with the defaultcompilescope. Conflict:mainhas version 2.18.11, and the branch value 2.18.10 is kept, because that bump is part of [v0.11.0] Version upgrades (backport #3183, #3184, #3182, #3196, #3195, #3223) #3233.A scan of every
pom.xmlon the branch, covering all<dependencies>and<plugins>blocks including profiles and management sections, found no other duplicates.Unblocks #3233, #3234 and #3235: after this PR merges, merge
v0.11.0into each of them. #3233 changes thejackson-databindversion line inexamples/client-v2/pom.xml, so that merge needs a small conflict resolution. The diagnosis is in #3233 (comment).Test
jackson-databindduplicate, which the second commit fixes.🤖 Generated with Claude Code
Note
Low Risk
Build/POM-only changes with no runtime library logic; the example module’s Jackson scope widens from test to compile, which is intentional for sample code.
Overview
Fixes Maven 3.10 CI failures caused by duplicate
maven-jar-pluginentries inclickhouse-jdbc-all: the two blocks are merged into one plugin with the existing archive settings and thejavadoc-jarexecution, and the extra pinned 3.3.0 declaration is removed so the version comes from parentpluginManagement(as onmain).In
examples/client-v2, duplicatejackson-databinddependencies are collapsed to a single 2.18.10 entry and thetestscope is dropped so examples compile against Jackson at runtime, not only in tests.Reviewed by Cursor Bugbot for commit 4dd0353. Bugbot is set up for automated code reviews on this repo. Configure here.