Repair stale stored query keys - #508
Conversation
75e8a6c to
f970de0
Compare
d1598a0 to
1ccc501
Compare
|
This is over-engineered. The ability to create a key and associated it to a QE is already possible. This should simply be described in the output when it occurs, baking the functionality into another flag is uncessary. |
|
Addressed in Verified with:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9e6095c. Configure here.
6d78b4f to
e5ca8db
Compare
93f7466 to
ce10368
Compare
|
Superseded by #538 in stack #563. |

Summary
cloud service query --repair-query-keyreplacement for one stored service credentialTests
cargo test -p clickhousectlcargo test -p clickhousectl --test cli_request_shape_test service_query_repair_replaces_only_the_exact_owned_key_and_binding -- --exactcargo test -p clickhousectl cloud::services::tests::parses_service_querycargo fmt --all --checkcargo clippy -p clickhousectl --all-targets -- -D warningsSubprocess coverage pins stored-key 401 and 403 guidance with no writes, exact binding replacement when the old management key is already absent, unrelated credential preservation, and safe legacy-record refusal.
Stack
This is the child of
issue-453-query-endpoint-readiness(PR #504) in gh-stack #505. It targets the parent branch; PR #504 should merge first.Closes #454
Stack created with GitHub Stacks CLI • Give Feedback