Skip to content

Disable telemetry in standalone local integration scripts - #511

Open
sdairs wants to merge 1 commit into
issue-465-postgres-diagnostics-helpfrom
issue-458-disable-script-telemetry
Open

Disable telemetry in standalone local integration scripts#511
sdairs wants to merge 1 commit into
issue-465-postgres-diagnostics-helpfrom
issue-458-disable-script-telemetry

Conversation

@sdairs

@sdairs sdairs commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Export DO_NOT_TRACK=1 at the standalone Postgres integration script boundary before it invokes clickhousectl.
  • Add a subprocess test that starts with DO_NOT_TRACK=0, runs the script against fake CLI/Docker/jq executables, and proves every spawned CLI inherits DO_NOT_TRACK=1.
  • Keep telemetry behavior and telemetry E2E coverage unchanged; those tests continue to remove the opt-out only while targeting their local wiremock endpoint.

Audit

  • scripts/test-postgres-integration.sh is the only executable repository integration/evaluation script that invokes clickhousectl; it is now protected at its own boundary.
  • scripts/check-openapi-drift.py invokes the Rust analyzer, not clickhousectl; the other scripts/*.py files do not launch the CLI.
  • install.sh installs the binary without executing it. npm/bin/cli.js is the user-facing product shim, not a repository test boundary, so it intentionally preserves user telemetry choices.
  • Every repository workflow already exports DO_NOT_TRACK=1; no workflow change is needed.

Tests

  • python3 -m unittest discover -s scripts/tests (44 passed)
  • python3 -m unittest scripts.tests.test_script_telemetry (1 passed)
  • bash -n scripts/test-postgres-integration.sh
  • shellcheck scripts/test-postgres-integration.sh
  • cargo test -p clickhousectl (768 passed)
  • cargo test -p clickhousectl --test telemetry_test (21 passed)
  • cargo clippy -p clickhousectl --all-targets -- -D warnings
  • cargo fmt --all --check
  • Real Docker battery not run locally: the configured OrbStack daemon socket is absent. The child local postgres edge cases CI check covers it.

Stack

Position 5 of 5 (top), based on #509.

Closes #458

Stack created with GitHub Stacks CLIGive Feedback

@sdairs sdairs changed the title issue 458 disable script telemetry Disable telemetry in standalone local integration scripts Aug 24, 2026
@sdairs
sdairs force-pushed the issue-458-disable-script-telemetry branch from 2568405 to dc9863d Compare August 25, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable telemetry in standalone local integration scripts

1 participant