Conversation
PickupManager.toItemStack now returns Optional<ItemStack> and will skip (return empty) for Villagers that are currently trading — it also closes the trader inventory to avoid issues. Call sites (VillagerEditMenu, HopperTicker, InteractListener) were updated to handle the Optional. Also updated plugin.yml authors to include 'Sylvye' and fixed a trailing newline.
Author
|
Video of the exploit released by the finders: https://www.youtube.com/watch?v=qoNpJUK7f9Q |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents temporary player-specific villager discounts from being serialized when picking up a villager during an active trade session.
A modified client could suppress the merchant close packet, pick up the villager, and place it again. This persisted the active
specialPrice, causing the discount to be applied repeatedly.Villager.isTrading()is true.This only changes the Paper implementation. Fabric and NeoForge behavior is unaffected.