Skip to content

feat: report the machine's isolation level in the upload metadata - #615

Open
GuillaumeLagrange wants to merge 1 commit into
mainfrom
report-runner-isolation
Open

GuillaumeLagrange wants to merge 1 commit into
mainfrom
report-runner-isolation

Conversation

@GuillaumeLagrange

Copy link
Copy Markdown
Contributor

The upload metadata now reports the isolation level of the machine running the benchmarks, as runner.isolation.

The machine running the job sets it in CODSPEED_RUNNER_ISOLATION; CodSpeed Macro Runners set it to strict, for example. The runner trims the value and leaves the field out when the variable is unset or blank, so uploads from other environments are unchanged.

The backend support is not released yet. Until it is, the field is ignored like any other unknown metadata.

Refs COD-4138

Read from CODSPEED_RUNNER_ISOLATION, set by the machine running the job.

Refs COD-4138
@GuillaumeLagrange
GuillaumeLagrange marked this pull request as ready for review November 5, 2026 14:13
@greptile-apps

greptile-apps Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Adds the machine’s reported isolation level to runner.isolation.

  • Uploads include the machine’s isolation level when it is set.

No actionable issues found. Tests were not run.

GuillaumeLagrange explicitly states that backend support is pending and unknown metadata is intentionally ignored.

Reviews (1) · Last reviewed commit: "feat: report the machine's isolation lev..." · Reviewed by Greptile

@codspeed

codspeed Bot commented Nov 5, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

2 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 8 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 23 untouched benchmarks
⏩ 24 skipped benchmarks1


Comparing report-runner-isolation (1fc0b3a) with main (8b62e4a)

Open in CodSpeed

Footnotes

  1. 24 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant