Repository navigation
feat: report the machine's isolation level in the upload metadata - #615
GuillaumeLagrange wants to merge 1 commit into
Conversation
Read from CODSPEED_RUNNER_ISOLATION, set by the machine running the job. Refs COD-4138
[Low impact] The PR appears safe to merge. SummaryAdds the machine’s reported isolation level to
No actionable issues found. Tests were not run. GuillaumeLagrange explicitly states that backend support is pending and unknown metadata is intentionally ignored. Reviews (1) · Last reviewed commit: "feat: report the machine's isolation lev..." · Reviewed by Greptile |
Merging this PR will not alter performance2 warnings
Comparing Footnotes
|
The upload metadata now reports the isolation level of the machine running the benchmarks, as
runner.isolation.The machine running the job sets it in
CODSPEED_RUNNER_ISOLATION; CodSpeed Macro Runners set it tostrict, for example. The runner trims the value and leaves the field out when the variable is unset or blank, so uploads from other environments are unchanged.The backend support is not released yet. Until it is, the field is ignored like any other unknown metadata.
Refs COD-4138