249 reports page#281
Merged
Merged
Conversation
… reports endpoints for generating a report
nshoreibah-kvyo
approved these changes
Jul 10, 2026
nshoreibah-kvyo
left a comment
nshoreibah-kvyo
left a comment
There was a problem hiding this comment.
Just one small request, going to approve!
| } | ||
|
|
||
| // Generate handler — POST /reports/generate { project_id, file_type } | ||
| async function handleGenerate() { |
There was a problem hiding this comment.
Nit: Can we maybe put this in a custom hook? Just since this file is pretty big
There was a problem hiding this comment.
And to separate the api logic from the jsx
nourshoreibah
approved these changes
Jul 10, 2026
nourshoreibah
approved these changes
Jul 10, 2026
tsudhakar87
approved these changes
Jul 12, 2026
tsudhakar87
left a comment
tsudhakar87
left a comment
Contributor
There was a problem hiding this comment.
echoing Nour's comment but I think this looks good overall!
| } | ||
|
|
||
| // Generate handler — POST /reports/generate { project_id, file_type } | ||
| async function handleGenerate() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
#249
📝 Description
Created the reports page according to the figma design. Connected to backend by using GET /reports to populate the table & POST /report for the "Generate Report" Modal.
Briefly list the changes made to the code:
✔️ Verification
Ran the tests & checked on local host to make sure it matched the figma design
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!
Not sure if this is already a ticket or if I missed it in the code, but I don't think I saw a delete endpoint for the reports. Also, I didn't create the frontend for the schedule view, so that will be a future ticket too I believe.