[Feature request] support object in directive field to method params #360

Activity

1. Code-Hex commented on May 5, 2023

   

   Code-Hex

   on May 5, 2023

   Owner

   More actions

   @erwan-joly

   input ComponentInput {
     type: ButtonComponentType!
     name: String! @required(msg: "Hello")
     event: EventInput
     child: ComponentInput
     childrens: [ComponentInput]
   }

   Then generated:

   export function ComponentInputSchema(): yup.ObjectSchema<ComponentInput> {
     return yup.object({
       child: yup.lazy(() => ComponentInputSchema()).optional(),
       childrens: yup.array(yup.lazy(() => ComponentInputSchema())).defined().nullable().optional(),
       event: yup.lazy(() => EventInputSchema()).optional(),
       name: yup.string().defined().nonNullable().required("Hello"), // This one
       type: ButtonComponentTypeSchema.nonNullable()
     })
   }

   This directive works even if it is not defined as a GraphQL schema.

   Or does the request want to assign default error messages? (to defined and nullable, etc)
2. erwan-joly commented on May 5, 2023

   

   erwan-joly

   on May 5, 2023

   Author

   More actions

   yeah the idea is to be able to define the error message for those in my example which I can already do in yup but can't in zod because they use object parameter and the only thing we can use as param from my understanding are string and regexp

   z.string().string({required_error: 'The field is required.'})

   Additionally we can't reuse the same method in zod oposite to yup.

   this is valid in yup: yup.number().defined().defined().defined().defined() but invalid in zod.
3. Code-Hex commented on May 13, 2023

   

   Code-Hex

   on May 13, 2023

   Last edited by Code-Hex

   Owner

   More actions

   Ah, I think I understand.
   Would it be feasible to set up something like this for example?

   config:
     required: $1
       errorMessage: $1
       applyTo: defined # will be generated method

   GraphQL Schema looks like this.

   input ComponentInput {
     type: ButtonComponentType!
     name: String! @required(errorMessage: "Hello")
     event: EventInput
     child: ComponentInput
     childrens: [ComponentInput]
   }

   The expected generation is

   export function ComponentInputSchema(): yup.ObjectSchema<ComponentInput> {
     return yup.object({
       child: yup.lazy(() => ComponentInputSchema()).optional(),
       childrens: yup.array(yup.lazy(() => ComponentInputSchema())).defined().nullable().optional(),
       event: yup.lazy(() => EventInputSchema()).optional(),
       name: yup.string().defined("Hello").nonNullable(), // this one
       type: ButtonComponentTypeSchema.nonNullable()
     })
   }

   However, this method is not very intuitive for first-time users.
4. erwan-joly commented on May 13, 2023

   

   erwan-joly

   on May 13, 2023

   Author

   More actions

   Yes something like this would works I think

   👍React with 👍1Reacted by Kei Kamikawa
5. Code-Hex commented on Apr 25, 2026

   

   Code-Hex

   on Apr 25, 2026

   Owner

   More actions

   Fixed in #1423. Directive configuration now supports object arguments and recursively substitutes directive argument values into the configured schema template.
6. Code-Hex

   closed this as completedon Apr 25, 2026