DifferencesBetweenSpanAndMemoryInCSharp: retarget net10.0, return the slice from both benchmarks - #2129
Open
vladimir-pecanac-main wants to merge 1 commit into
Conversation
… slice from both benchmarks Both benchmark methods returned void and discarded their slice, so the published means (0.2760 ns / 0.0239 ns) measured an empty method rather than the operation. Returning the slice makes BenchmarkDotNet consume the result and produces real figures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both benchmark methods in
SpanMemoryBenchmarkreturnedvoidand discarded their slice, so the published means (0.2760 ns / 0.0239 ns) measured an empty method rather than the operation. Returning the slice makes BenchmarkDotNet consume the result.SliceAsMemorynow returnsMemory<int>,SliceAsSpannow returnsSpan<int>net8.0->net10.0Measured on net10.0 (.NET 10.0.10, BenchmarkDotNet 0.13.12):
SliceAsMemory2.8710 ns,SliceAsSpan0.5306 ns, 0 B allocated. Article /csharp-differences-between-span-and-memory/ updated with these figures.