Repository navigation
Bogus in C#: net10.0, UseSeeding, seeded generator, email test fix - #2300
Open
vladimir-pecanac-main wants to merge 2 commits into
Open
vladimir-pecanac-main wants to merge 2 commits into
vladimir-pecanac-main wants to merge 2 commits into
Conversation
…tor, email test fix Retarget both projects to net10.0 (Bogus 35.6.5, EF Core 10.0.13, direct System.Security.Cryptography.Pkcs 10.0.13 for the SqlClient advisory; xunit 2.9.3, runner 4.0.1, Test SDK 18.11.0, coverlet 10.1.0). EmployeeContext seeds through UseSeeding() in OnConfiguring(); OnModelCreating() and HasData() removed. GetSeededEmployeesFromDb() calls Migrate() instead of EnsureCreated(); the employee generator keeps its Vehicles rule. Add GenerateRepeatableVehicles(int seed) and a test that the same seed gives the same vehicles. The email test asserts StartsWith(FirstName): Bogus does not always use the last name.
Bogus slugifies the name when it builds the email (D'angelo becomes Dangelo), so StartsWith(FirstName) failed about 2 to 3 times in 10,000 runs. The test now asserts StartsWith(Utils.Slugify(FirstName)); 10,000 probe runs give 0 failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample for https://code-maze.com/data-generation-bogus-dotnet/ (folder dotnet-client-libraries/BogusNugetPackage only).