Repository navigation
Type Checking and Casting in C#: move to .NET 10 - #2307
Open
vladimir-pecanac-main wants to merge 1 commit into
Open
vladimir-pecanac-main wants to merge 1 commit into
vladimir-pecanac-main wants to merge 1 commit into
Conversation
… add tests Both projects move to net10.0 and the test packages to Microsoft.NET.Test.Sdk 18.11.0, xunit 2.9.3, xunit.runner.visualstudio 4.0.1 and coverlet.collector 10.1.0. The is-operator test declares its values as object, which removes the CS0183 and CS0184 warnings. Two tests added: is against GetType() on a derived instance, and an overflowing long cast in unchecked and checked contexts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retargets both projects in csharp-basic-topics/TypeCheckingAndCastingInCSharp to net10.0 and updates the test packages (Microsoft.NET.Test.Sdk 18.11.0, xunit 2.9.3, xunit.runner.visualstudio 4.0.1, coverlet.collector 10.1.0). The is-operator test now declares its values as object, which removes the CS0183 and CS0184 warnings and matches the updated article snippet, and two tests are added: is against GetType() on a Horse held in an Animal variable, and a long.MaxValue cast to int that gives -1 unchecked and throws OverflowException checked. Build has 0 warnings and all 19 tests pass.