Repository navigation
Char array to string: net10.0, working solution file, new tests and a benchmark - #2315
Open
vladimir-pecanac-main wants to merge 1 commit into
Conversation
… benchmark project The solution file mapped project GUIDs that did not exist, so CI built nothing and ran no tests. Regenerated it with all three projects. Both projects move to net10.0 with MSTest 4.5.1, Microsoft.NET.Test.Sdk 18.11.0 and coverlet.collector 10.1.0. Program.cs uses top-level statements and adds the part-of-array, separator and single-char examples. Five new tests cover them and the null-array behaviour. A BenchmarkDotNet 0.15.8 project compares the constructor, string.Concat and string.Join, and passes command-line args to the runner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The solution file in strings-csharp/ConvertCharArray2String mapped project GUIDs that did not exist, so CI built nothing and ran no tests; it is regenerated with all three projects. Both projects move to net10.0 with MSTest 4.5.1, Microsoft.NET.Test.Sdk 18.11.0 and coverlet.collector 10.1.0, Program.cs uses top-level statements and adds the part-of-array, separator and single-char examples, five new tests cover them and the null-array behaviour, and a new BenchmarkDotNet 0.15.8 project compares the string constructor with string.Concat and string.Join, passing command-line args to the runner.