Stop claat focus scrolling day plans to the Problem Solving Workshop - #4
Merged
Merged
Conversation
codelab-elements.js focuses the current step, which scrolls an embedding page to the iframe. When framed, force preventScroll on focus() calls.
✅ Deploy Preview for cyf-codewars-workshops ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
abdishakoor-dev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three ITP curriculum day plan page embed a Problem Solving Workshop from codewars-workshops.codeyourfuture.io (JS Fundamentals sprint 3, Testing sprints 1 and 3). About a second after load, each one jumps down to the workshop iframe, whether the trainee opened the page at the top or at a section link such as #screen-safari. Example: https://curriculum.codeyourfuture.io/itp/testing/sprints/1/day-plan/#screen-safari
This happens because claat's codelab-elements.js focuses the current step, and focusing inside an iframe scrolls the parent page.
A small script now loads before codelab-elements.js. When the page is framed, it forces preventScroll on focus() calls. Opened directly, pages behave as before, and keyboard step navigation still works. build.sh fails if the script is not injected into every page.