Skip to content

London | 26-ITP-Sep | Ebrahim Moqbel | sprint 2 | Book library - #575

Open
Ebrahim-Moqbel wants to merge 1 commit into
CodeYourFuture:mainfrom
Ebrahim-Moqbel:book-library
Open

Ebrahim-Moqbel wants to merge 1 commit into
CodeYourFuture:mainfrom
Ebrahim-Moqbel:book-library

Conversation

@Ebrahim-Moqbel

@Ebrahim-Moqbel Ebrahim-Moqbel commented Aug 21, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1122

Changelist

Have debugged the book library files

Questions

N/A

@github-actions

This comment has been minimized.

@Ebrahim-Moqbel Ebrahim-Moqbel changed the title London | 26-ITP-May | Ebrahim Moqbel | Book library London | 26-ITP-May | Ebrahim Moqbel | sprint 2 | Book library Aug 21, 2026
@Ebrahim-Moqbel Ebrahim-Moqbel added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module labels Aug 21, 2026
@Ebrahim-Moqbel Ebrahim-Moqbel reopened this Sep 9, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 9, 2026
@Ebrahim-Moqbel Ebrahim-Moqbel changed the title London | 26-ITP-May | Ebrahim Moqbel | sprint 2 | Book library London | 26-ITP-Sep | Ebrahim Moqbel | sprint 2 | Book library Sep 9, 2026
@github-actions

This comment has been minimized.

@Ebrahim-Moqbel Ebrahim-Moqbel added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 9, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Sep 14, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, did you try testing this before opening the PR? when I attempt to interact with the form on the page it just reloads it and doesn't display the entered books

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants