Glasgow | 10 July 26 | Chan Yat Long | sprint 2 | Data groups - #1243
Open
Motorcycle-lab wants to merge 13 commits into
Open
Glasgow | 10 July 26 | Chan Yat Long | sprint 2 | Data groups#1243Motorcycle-lab wants to merge 13 commits into
Motorcycle-lab wants to merge 13 commits into
Conversation
Motorcycle-lab
added
📅 Sprint 2
Motorcycle-lab
changed the title
Motorcycle-lab
added
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 27, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Answering your Q: Do codewars katas, check other's solutions, and then in future tasks, try to apply patterns you have learned from memory
Good work on the task, there is one I think you could improve
| return false; | ||
| } | ||
|
|
||
| if (key in object) { |
There was a problem hiding this comment.
Can this final condition and return be simplified?
Author
There was a problem hiding this comment.
yes return key in object;
LonMcGregor
added
Reviewed
Motorcycle-lab
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
for committing , clean pull request
Questions
How can I learn new function efficiently ?